Skip to content

Security: HTTP requests are performed without timeout safeguards #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −1
Open

Security: HTTP requests are performed without timeout safeguards #1683

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10d9b01
fix(security): http requests are performed without timeout safegu
tomaioo Apr 15, 2026
4bf151f
fix: address review feedback — Suggest changing to below in case the …
tomaioo Apr 15, 2026
579e7d3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion auto_round/compressors/mllm/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ def fetch_image(path_or_url):
if os.path.isfile(path_or_url):
image_obj = Image.open(path_or_url)
elif path_or_url.startswith("http://") or path_or_url.startswith("https://"):
image_obj = Image.open(requests.get(path_or_url, stream=True).raw)
try:
response = requests.get(path_or_url, stream=True, timeout=(3, 10))
response.raise_for_status()
image_obj = Image.open(response.raw)
except (requests.exceptions.RequestException, OSError) as e:
raise RuntimeError(f"Failed to fetch image from url: {path_or_url}") from e
else:
raise TypeError(f"{path_or_url} neither a path or url.")

Expand Down