Open
Conversation
Contributor
|
could someone from MSFT to review AzCVMEmu? |
ksayid
reviewed
Mar 4, 2026
haitaohuang
force-pushed
the
rebind2
branch
2 times, most recently
from
4c53a30 to
aa35f45
Compare
bodzhang
reviewed
Mar 5, 2026
| // RebindingInfo layout (56 bytes minimum): | ||
| // [0..8] mig_request_id (u64) | ||
| // [8] rebinding_src (u8) | ||
| // [9] has_init_data (u8) - 0 for emulation |
Contributor
There was a problem hiding this comment.
In emulation mode, with no init_data for the StartRebinding request, what code flow in MigTD is bypassed?
Contributor
Author
There was a problem hiding this comment.
Basically the src serves as the init migtd
| populate_servtd_fields(binding_handle, target_td_uuid); | ||
| } | ||
|
|
||
| /// Populate MSK_FIELDS with ServTD extension data derived from the TD report. |
Contributor
There was a problem hiding this comment.
"MSK_FIELDS" name is a confusing. Probably from previous version of the emulation code for "TDCS_FIELD_MIG_ENC_KEY ". "TDCS_FIELDS" is probably a better name.
Contributor
Author
There was a problem hiding this comment.
MSK_FILEDS is a static storage for emulated MSK and TDCS fields. I'll rename to BOULD_FIELDS instead and remove reference from comments
- Remove MIGTD_ROOT_CA_FILE for policy_v2 (root CA not needed policy v2) - Extract quote data into reusable tdx-mock-data crate - Generate the mock report from the quote data, remove hard coded report - Compute SHA384 hashes at runtime for report_mac integrity Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Populate emulated ServTD extension fields (init_servtd_info_hash, init_attr, cpusvn, tee_tcb_svn) from TD report data when setting up rebinding emulation. Previously these fields were all zeros, causing verify_servtd_hash to fail with InvalidTdReport during TLS handshake. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
Add two new test matrix entries for rebinding: - Rebind Prepare (Skip RA): builds with policy_v2 + skip-RA features - Rebind Prepare (Mock Report): builds with mock report, generates policy from mock data before running rebind test Also update log checking to handle rebind-specific log files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Haitao Huang <haitaohuang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.