Support spikeinterface#31
Draft
JoeZiminski wants to merge 15 commits into
Draft
Conversation
2512010 to
683f281
Compare
Collaborator
Author
|
Hey @oliche @rai-pranav this PR is not yet finished (requires tests and some further investigation into the memmapping) but I won't finish it until next week so this could be a good time for an interim review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(currently draft for discsussion)
This PR will add spikeinterface as a data backend.
The idea would be for
viewephysto take either a path to a.binfile, data array or a dictionary of spikeinterface recordings where the keys are the preprocessing step. e.g.then the checkboxes will be auto-populated with the keys and the data will be extracted from the relevant recording.
We can have a single
SpikeInterfaceDataModelthat holds this dict and exposes all of the requirements of theEphysBinViewer(see #30). The dict of recordings could live on theSpikeInterfaceDataModel, we can domy_recs[step].get_traces(...)and have some logic that every recording in the dict shares the same sampling rate, geometry etc.WDTY?