Fix pick-spikes auto-detect window and QSettings int cast#28
Merged
Conversation
oliche
added a commit
that referenced
this pull request
May 21, 2026
oliche
added a commit
that referenced
this pull request
May 21, 2026
* Add more on running through exec. * Add examples * Add examples. * Small tidy ups. * Fix typos. * Fix linting. * Remove stale create_app stub and add script API regression tests * Update changelog with PR references for #28 and #29 --------- Co-authored-by: JoeZiminski <Joseph.j.ziminski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18. Original fix by @JoeZiminski — rebased on main and cleaned up.
Changes
S_RANGE/TR_RANGEwith view-percentage-based values (2%/5% of current zoom) so the auto-detect window does not escape the visible range at high sample ratesviewBox_seismic.viewRange()public API instead of.state["viewRange"]internal dictself.plotItem_seismic.windowStatelineQSettings.value()returningstrfornfft/nperseginImShowSpectrogram, causingTypeErroron//— cast tointat the property level