Add option to view only a specific shank to BinaryFile#22
Open
JoeZiminski wants to merge 4 commits into
Open
Conversation
Draft
Member
|
Add an edit box, we'll use the syntax to filter using header.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a prototype PR but would be good to get your thoughts @oliche. For some data I have it sorted per-shank so it is nice to look only at that shank up-close. This PR adds an option to display only a selected shank.
I'm not sure if this is the best way to split the shank through the IBL API, I also only tested it for
spikeglx.Readerso not sure if it will work forReaderClass.In general this should be better tested, and will have to be updated a lot once loading from spikeinterface is also supported. In terms of testing, I wonder if its easier to maintain a list of things to test, as there may be a lot of upcoming changes (e.g. spikeinterface reader, loading sorting output). Once we are happy with the form we can add a load of tests?