Skip to content

Add option to view only a specific shank to BinaryFile#22

Open
JoeZiminski wants to merge 4 commits into
int-brain-lab:mainfrom
JoeZiminski:add_select_shank
Open

Add option to view only a specific shank to BinaryFile#22
JoeZiminski wants to merge 4 commits into
int-brain-lab:mainfrom
JoeZiminski:add_select_shank

Conversation

@JoeZiminski
Copy link
Copy Markdown
Collaborator

@JoeZiminski JoeZiminski commented Feb 17, 2026

This is a bit of a prototype PR but would be good to get your thoughts @oliche. For some data I have it sorted per-shank so it is nice to look only at that shank up-close. This PR adds an option to display only a selected shank.

I'm not sure if this is the best way to split the shank through the IBL API, I also only tested it for spikeglx.Reader so not sure if it will work for ReaderClass.

In general this should be better tested, and will have to be updated a lot once loading from spikeinterface is also supported. In terms of testing, I wonder if its easier to maintain a list of things to test, as there may be a lot of upcoming changes (e.g. spikeinterface reader, loading sorting output). Once we are happy with the form we can add a load of tests?

@JoeZiminski JoeZiminski changed the title Add select shank idx. Add option to view only a specific shank to BinaryFile Feb 17, 2026
@JoeZiminski JoeZiminski mentioned this pull request Feb 18, 2026
@oliche
Copy link
Copy Markdown
Member

oliche commented May 21, 2026

Add an edit box, we'll use the syntax to filter using header.
For example:

shank 0 selects only shank == 0
shank 1 3 selects shank one two and three
shank 1 3 2 selects from shank one to three with a 2 increment: so shanks 1 and 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants