Skip to content

Add examples and instructions for running in scripts#16

Closed
JoeZiminski wants to merge 6 commits into
int-brain-lab:mainfrom
JoeZiminski:add_exec
Closed

Add examples and instructions for running in scripts#16
JoeZiminski wants to merge 6 commits into
int-brain-lab:mainfrom
JoeZiminski:add_exec

Conversation

@JoeZiminski
Copy link
Copy Markdown
Collaborator

@JoeZiminski JoeZiminski commented Feb 12, 2026

Hey @oliche this PR expands the README a little to make it clear that if running through a script, you need to instantiate the Qt application yourself. It also highlights how viewephys can be used to create multiple windows at once.

I added an examples folder that contain a very small bin file. For me this is useful for quickly testing things manually, but I think it will be useful for users too who can quickly try out the functionality without having to have data handy etc.
LMKWYT!

Comment thread src/viewephys/gui.py Outdated
"""

easyqc.qt.create_app()
# easyqc.qt.create_app()
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick check on this, I don't think this is necessary (at least, removing it did not affect anything in my case). Just wanted to check it didn't break anything for you before deleting!

@JoeZiminski JoeZiminski marked this pull request as ready for review February 12, 2026 13:45
@JoeZiminski JoeZiminski requested a review from oliche February 12, 2026 16:43
@JoeZiminski JoeZiminski requested review from oliche and removed request for oliche May 21, 2026 10:06
@oliche
Copy link
Copy Markdown
Member

oliche commented May 21, 2026

Thanks @JoeZiminski! Rebased on main, removed a stale create_app stub introduced by the easyqc refactor, and added regression tests for the script API — opened as #29 with your original commits preserved.

@oliche oliche closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants