Add examples and instructions for running in scripts#16
Closed
JoeZiminski wants to merge 6 commits into
Closed
Conversation
JoeZiminski
commented
Feb 12, 2026
| """ | ||
|
|
||
| easyqc.qt.create_app() | ||
| # easyqc.qt.create_app() |
Collaborator
Author
There was a problem hiding this comment.
Just a quick check on this, I don't think this is necessary (at least, removing it did not affect anything in my case). Just wanted to check it didn't break anything for you before deleting!
e351b4f to
f7682a4
Compare
Member
|
Thanks @JoeZiminski! Rebased on main, removed a stale create_app stub introduced by the easyqc refactor, and added regression tests for the script API — opened as #29 with your original commits preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @oliche this PR expands the README a little to make it clear that if running through a script, you need to instantiate the Qt application yourself. It also highlights how
viewephyscan be used to create multiple windows at once.I added an
examplesfolder that contain a very small bin file. For me this is useful for quickly testing things manually, but I think it will be useful for users too who can quickly try out the functionality without having to have data handy etc.LMKWYT!