Refactor configs#15
Draft
JoeZiminski wants to merge 2 commits into
Draft
Conversation
oliche
reviewed
Feb 5, 2026
Member
There was a problem hiding this comment.
Maybe we should name this module constants.py ?
Collaborator
Author
There was a problem hiding this comment.
That would work, my only thought is would this be set by some point by users through the gui and remembered over sessions? or are these likely to suite all users and just be internal constants?
Member
There was a problem hiding this comment.
For this qt guis have the QSettings, I find them very handy as you don't have to fiddle with every OS application data. But
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(will come back to this later, after some refactorings and adding in spike peaks from spikeinterface)
Playing around with refactoring configs, draft ATM. In general the aims are to:
EphysViewerso that all required variables are passed as arguments toviewephys