chore: Allow to change cwd of transcoder ffmpeg #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help managing the two pass encoding logfiles
elthariel
changed the title
Collaborator
|
Hi again @elthariel! Thanks for opening the PR, I'll try to take a look at it next week! |
Collaborator
|
Okay, so taking a better look I don't think this needs to be handled on the gem level. The way you should do it is by wrapping the transcoding calls in a Do you think this solves your problem? Or is there something very specific that I don't yet see about your workflow? |
bajankristof
added
question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned earlier, I want to support 2 pass VP9 encoding in my app, and the process produces a logfile in the current working directory.
Could have either somehow managed to pass an absolute path to the encoder, but it would have been a bit complicated or would have broken the re-usability of presets
Or I could just
chdirthe spawned process.I went for the latter. This add a bit more code that I'd have liked, but when I added the spawn opt to FFMPEG::IO methods, I thought it would be better to add the option everywhere for homogeneity of the interface.
WDYT ?