Skip to content

export route handler types (#2756) [bump to v1.0.48]#2756

Merged
drew-harris merged 4 commits into
mainfrom
drewh/export-route-handler-types
Jun 10, 2026
Merged

export route handler types (#2756) [bump to v1.0.48]#2756
drew-harris merged 4 commits into
mainfrom
drewh/export-route-handler-types

Conversation

@drew-harris

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19d101a7-a2c5-4d76-b1b7-032372349811

📥 Commits

Reviewing files that changed from the base of the PR and between 455d9fb and 5821e90.

📒 Files selected for processing (2)
  • client/packages/core/src/createRouteHandler.ts
  • client/packages/version/src/version.ts
✅ Files skipped from review due to trivial changes (2)
  • client/packages/version/src/version.ts
  • client/packages/core/src/createRouteHandler.ts

📝 Walkthrough

Walkthrough

Adds a core type-only routeHandler protocol (including 'sync-user'), updates createRouteHandler to use those types, re-exports the types from framework/admin/platform packages, and increments the package version to v1.0.48.

Changes

Route Handler Protocol Types

Layer / File(s) Summary
Core protocol definition and export
client/packages/core/src/routeHandlerProtocol.ts, client/packages/core/src/index.ts
Introduces InstantRouteHandlerPayloadByType, InstantRouteHandlerType, and generic InstantRouteHandlerBody<Type> and re-exports them from core.
createRouteHandler type updates
client/packages/core/src/createRouteHandler.ts
Replaces ad-hoc User/body typings with protocol types: createUserSyncResponse now uses the 'sync-user' payload type and the POST body is Partial<InstantRouteHandlerBody>.
Framework & platform re-exports
client/packages/admin/src/index.ts, client/packages/platform/src/index.ts, client/packages/react/src/index.ts, client/packages/solidjs/src/index.ts, client/packages/svelte/src/lib/index.ts, client/packages/vue/src/index.ts
Each package imports the new core route-handler types and re-exports them from its public entrypoint.
Version bump
client/packages/version/src/version.ts
Updates exported version constant from v1.0.47 to v1.0.48.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • dwwoelfel
  • nezaj
  • stopachka
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author. The pull request lacks any explanatory text about the changes or their rationale. Add a description explaining the purpose of exporting these route handler types and any context for consumers of these APIs.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: exporting three route handler types across multiple packages in the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drewh/export-route-handler-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

@nezaj nezaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one nit!

Comment thread client/packages/core/src/routeHandlerProtocol.ts
@drew-harris drew-harris changed the title export route handler types export route handler types (#2756) [bump to v1.0.48] Jun 10, 2026
@drew-harris drew-harris merged commit 807eb69 into main Jun 10, 2026
30 checks passed
@drew-harris drew-harris deleted the drewh/export-route-handler-types branch June 10, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants