⚡ Bolt: Remove synchronous X call in drawing path#183
⚡ Bolt: Remove synchronous X call in drawing path#183google-labs-jules[bot] wants to merge 1 commit intodevfrom
Conversation
Removing `XSync` from `drw_map` eliminates a blocking round-trip to the X server on every draw operation. This improves responsiveness and reduces latency during frequent updates, such as bar redrawing or mouse interactions. The X11 protocol guarantees order of operations, so `XCopyArea` remains safe without explicit synchronization.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
⚡ Bolt: Remove synchronous X call in drawing path
💡 What: Removed
XSync(drw->dpy, False);fromdrw_mapindrw.c.🎯 Why:
XSyncforces the client to wait for the X server to process the request, creating significant latency (network round-trip + context switch) for every drawing operation. This is a bottleneck for UI updates like the status bar.📊 Impact: Reduces latency for all drawing operations using
drw_map. In high-frequency update scenarios (e.g., animations, typing), this prevents the window manager from blocking on the X server.🔬 Measurement: Verified that the project builds correctly with
make clean && make. Visual verification (via code review) confirms that event loop processing will implicitly handle flushing, makingXSyncredundant.PR created automatically by Jules for task 7670473945907552637 started by @paperbenni