Skip to content

Span stack config#492

Merged
arjun-rajappa merged 23 commits intomasterfrom
span-stack-config
Feb 23, 2026
Merged

Span stack config#492
arjun-rajappa merged 23 commits intomasterfrom
span-stack-config

Conversation

@arjun-rajappa
Copy link
Contributor

@arjun-rajappa arjun-rajappa commented Feb 8, 2026

No description provided.

@arjun-rajappa
feat(span_stack): Add initial config structure
e3cc2df 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): read config from env vars
a2675af 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): retain previous default of 30 lines and append stac…
87a7189 
…ks of errored span

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): add config to reflect config source
e057c46 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): add tests for different config scenarios
6150db2 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): read config from yml configuration
cc890c0 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): add tests for yml configuration read
6956693 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): fix rubucop linting failures
89f5f9a 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): read config from the agent discovery
a8d9455 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): read config from the agent discovery
81dd7bf 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): test config read from agent
909cc61 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): read span filtering right after discovery
0395ab8 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): test span filtering config right after discovery
c808b03 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): support different technology specific config
bcaebcb 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): test technology specific configs
6c887e5 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): modify span stack t6o consider technology specific …
2a39b88 
…config

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): fix rubocop linting failures
c458aa7 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
chore(currency): update tests to support dalli 5.0.0
1287b8b 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): use new config structure for backtrace
a6f8267 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
CagriYonca
CagriYonca previously requested changes Feb 16, 2026
View reviewed changes
Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments 🙏

@arjun-rajappa
feat(span_stack): refactor to remove duplicated code
a45e8c0 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
feat(span_stack): refactor to remove duplicated code
c5b67e9 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
chore: fix rubocop failures
e65aaa6 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
GSVarsha
GSVarsha reviewed Feb 18, 2026
View reviewed changes
GSVarsha
GSVarsha requested changes Feb 18, 2026
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests

@arjun-rajappa
feat(span_stack): reaorder config read
4f5fa1e 
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 19, 2026 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
3 New issues
2 Accepted issues

Measures
0 Security Hotspots
95.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arjun-rajappa arjun-rajappa self-assigned this Feb 19, 2026
GSVarsha
GSVarsha approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@arjun-rajappa arjun-rajappa dismissed CagriYonca’s stale review February 23, 2026 05:17

Approved by another team member

@arjun-rajappa arjun-rajappa merged commit 21f2edf into master Feb 23, 2026
269 checks passed
@arjun-rajappa arjun-rajappa deleted the span-stack-config branch February 23, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSVarsha GSVarsha GSVarsha approved these changes

@CagriYonca CagriYonca Awaiting requested review from CagriYonca

Assignees

@arjun-rajappa arjun-rajappa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arjun-rajappa @CagriYonca @GSVarsha