fix(tracer): restore OpenTelemetry API compliance for context parameter#848
fix(tracer): restore OpenTelemetry API compliance for context parameter#8481mike1451 wants to merge 2 commits intoinstana:mainfrom
Conversation
Add 'context' parameter to start_span() and start_as_current_span() while maintaining backward compatibility with 'span_context' parameter. Fixes TypeError with OpenTelemetry-compliant libraries (regression from c4d4251). Includes 15 new tests, all 20 tests pass. Signed-off-by: Michael Ramos <ramosm@us.ibm.com>
|
❌ @1mike1451 the
📝 What should I do to fix it?All proposed commits should include a sign-off in their messages, ideally at the end. ❔ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO, reformatted for readability:
Contributors sign-off that they adhere to these requirements by adding a Git even has a |
…Tel context Signed-off-by: Michael Ramos <ramosm@us.ibm.com>
Add 'context' parameter to start_span() and start_as_current_span() while maintaining backward compatibility with 'span_context' parameter.
Fixes TypeError with OpenTelemetry-compliant libraries (regression from c4d4251). Includes 15 new tests, all 20 tests pass.
fixes: #847