Skip to content

[Currency Bot] Bumped redis from 5.12.1 to 6.0.0 #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
instanacd wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Currency Bot] Bumped redis from 5.12.1 to 6.0.0 #2578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3240ef
build: bumped redis from 5.12.1 to 6.0.0
Jun 2, 2026
0066308
chore: added node constraint
aryamohanan Jun 3, 2026
606c8c6
chore: updated
aryamohanan Jun 3, 2026
b67085c
chore: instrumentation fix
aryamohanan Jun 3, 2026
e5e8494
chore: instrumentation fix
aryamohanan Jun 3, 2026
e9e3ea3
chore: instrumentation fix
aryamohanan Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions currencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,10 +972,11 @@
"core": false,
"versions": [
{
"v": "5.12.1"
"v": "6.0.0",
"node": ">=20"
},
{
"v": "5.8.3"
"v": "5.12.1"
},
{
"v": "4.7.1"
Expand Down Expand Up @@ -1334,4 +1335,4 @@
}
]
}
]
]
10 changes: 7 additions & 3 deletions packages/core/src/tracing/instrumentation/databases/redis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,13 @@
}

function instrument(redis) {
// NOTE: v4 no longer exposes the RedisClient. We need to wait till `createClient` get's called
// to get the instance of the redis client
if (!redis.RedisClient) {
// NOTE: Redis versions differ in export shape:
// v4/v5: are strictly factory-based (createClient/createCluster) and do not expose RedisClient.
// v6: expose RedisClient again, but this does NOT imply legacy/class-based behavior.
// RedisClient presence alone cannot be used to distinguish v3 from newer versions.
const isLegacyClassAPI = redis.RedisClient?.prototype && typeof redis.createClient !== 'function';

if (!isLegacyClassAPI) {

Check warning on line 57 in packages/core/src/tracing/instrumentation/databases/redis.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Unexpected negated condition. 


See more on https://sonarcloud.io/project/issues?id=instana_nodejs&issues=AZ6L8EkEQ2--oDhGjX2T&open=AZ6L8EkEQ2--oDhGjX2T&pullRequest=2578
// redis automatically loads @redis/client, which can trigger a second instrumentation call.
// We track the instrumentation status via `isRedisClientInstrumented and skip second time.
if (isRedisClientInstrumented) {
Expand Down