Creation of a config file + changes (#3)#7
Open
quentin-vigne wants to merge 1 commit intoinspirezonetech:mainfrom
Open
Creation of a config file + changes (#3)#7quentin-vigne wants to merge 1 commit intoinspirezonetech:mainfrom
quentin-vigne wants to merge 1 commit intoinspirezonetech:mainfrom
Conversation
Added the config file containing the keyword + changed the main script to use this config file
funbeedev
requested changes
Oct 20, 2020
Member
funbeedev
left a comment
funbeedev
left a comment
There was a problem hiding this comment.
Hi, can you please do the following and resubmit the pull request:
- Remove "pycache/config.cpython-38.pyc" from the commit
- Remove "geckodriver.log" from the commit
- Submit your changes under a different branch name. dont use the default branch "main"
Thanks!
Member
|
@quentin-vigne Any updates? :) |
Member
|
Hi @quentin-vigne do you still want to work on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR
Added the config file containing the keyword + changed the main script to use the config file
Solving issue #3