chore: provide new_unchecked constructors for headers#232
Merged
Conversation
new_unchecked constructors for headers
4 tasks
Evalir
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
new_uncheckedconstructors toSignetHeaderV1andSignetHeaderV2that skip invariant validation, allowing infallible construction from trusted sources (e.g. headers already parsed and stored in the storage crates)Motivation
Storage crates store plain
alloy::consensus::Headervalues. When reading these back and wrapping them as signet header types, the validation inTryFrom<Header>is redundant - the data has already been validated on the way in. Thenew_uncheckedconstructors allow direct construction without re-checking invariants, which is both simpler (infallible) and avoids unnecessary work.Test plan
signet-typestests pass (cargo t -p signet-types)--all-featuresand--no-default-featuresnew_uncheckedto construct headers from stored data