Skip to content

fix: use new sdk#81

Merged
prestwich merged 2 commits into
mainfrom
prestwich/new-sdk
May 8, 2025
Merged

fix: use new sdk#81
prestwich merged 2 commits into
mainfrom
prestwich/new-sdk

Conversation

@prestwich
Copy link
Copy Markdown
Member

@prestwich prestwich commented May 8, 2025

use the new constants crate

* refactor: update config to use derive

* fix: not optional

* refactor: normalize tracing imports
Copy link
Copy Markdown
Member Author

prestwich commented May 8, 2025

@prestwich prestwich marked this pull request as ready for review May 8, 2025 19:05
@prestwich prestwich requested review from Evalir and dylanlott as code owners May 8, 2025 19:05
Copy link
Copy Markdown
Member

@rswanson rswanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also remove the env vars and replace them with values from the pecorino chain constants?

@prestwich
Copy link
Copy Markdown
Member Author

no. that comes later

@prestwich prestwich merged commit 4f8f6ae into main May 8, 2025
5 checks passed
@prestwich prestwich deleted the prestwich/new-sdk branch May 8, 2025 20:53
This was referenced May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants