refactor: update config to use derive#75
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/new-config
branch
2 times, most recently
from
07ee54f to
e21ad9d
Compare
Evalir
reviewed
May 7, 2025
Comment on lines
+48
to
+49
| 1740681556, // pecorino start timestamp as sane default | ||
| 0, 1, |
Member
Author
There was a problem hiding this comment.
I don't know what these are, so i just moved them as is. @dylanlott can make a change here
This was referenced May 7, 2025
dylanlott
requested changes
May 8, 2025
Contributor
dylanlott
left a comment
dylanlott
left a comment
There was a problem hiding this comment.
FromEnv declarations need a second look.
| use tokio::time::timeout; | ||
|
|
||
| #[derive(Debug, Clone, FromEnv)] | ||
| struct Config { |
Contributor
There was a problem hiding this comment.
Maybe call this something like SubmitConfig to clearly distinguish it from the BuilderConfig
Member
Author
There was a problem hiding this comment.
they're in different targets so i dont think we need to distinguish
prestwich
force-pushed
the
prestwich/new-config
branch
from
66086e4 to
da29daa
Compare
prestwich
force-pushed
the
prestwich/new-config
branch
from
1ddfbda to
2280e57
Compare
dylanlott
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the builder to use the FromEnv derive
@rswanson this changes the names of the slot calc variables to match them as used in other repos