Repository navigation
fix: prevent member self-promotion to admin - #42
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix — Member Self-Promotion to Admin
Fixed a critical privilege-escalation vulnerability where authenticated members could directly modify their
rolefield and promote themselves to administrator.Changes
userscolumns for normal clients.rolefield through the Supabase API.admin_update_user_role()PostgreSQL RPC for role management.is_admin()authorization checks to the role-management RPC.memberandadmin.MembersAdmin.tsxto use the secure RPC instead of directly updating theuserstable.Security Flow
Normal Member
→ Direct role update
→ Database denied
Administrator
→
admin_update_user_role()→
is_admin()validation→ Role updated
→ Audit log recorded
This closes the member → admin privilege-escalation path identified during the security audit.