Repository navigation
chore(pulse): ship the donut demo in the release - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The release now ships the donut demo as
pulse-donut, next topulse-livedemoandpulse-multidemo. GoReleaser builds it fromexamples/donutfor Linux, macOS and Windows (amd64 and arm64). The archive has noidsfilter, so every platform archive gets the new binary. The release section ofdocs/development.mdnames it.A snapshot release (
goreleaser release --snapshot --clean --skip=publish) on a copy of the branch built every archive. Each one holdspulse-livedemo,pulse-multidemoandpulse-donut.Left for later:
goreleaser checkfails becausearchives.formatandarchives.format_overrides.formatare deprecated. The keys were there before this change, and the release still works.Issues
None.
Type of Change
Checklist
gofmt,go vet).go test -race ./...) and everything builds (go build ./...andgo -C examples build ./...).