[FIX] stock_voucher_ux: asignar números de remito antes de imprimir#951
Open
fw-bot-adhoc wants to merge 1 commit into
Open
[FIX] stock_voucher_ux: asignar números de remito antes de imprimir#951fw-bot-adhoc wants to merge 1 commit into
fw-bot-adhoc wants to merge 1 commit into
Conversation
stdout: Auto-merging stock_declared_value/__manifest__.py CONFLICT (content): Merge conflict in stock_declared_value/__manifest__.py CONFLICT (modify/delete): stock_voucher_ux/models/stock_picking.py deleted in 8b1493d and modified in ff458cb. Version ff458cb of stock_voucher_ux/models/stock_picking.py left in tree. stderr:
Collaborator
|
|
Contributor
Author
|
@mav-adhoc @les-adhoc cherrypicking of pull request #941 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
Al usar el botón Print Vouchers en un remito con
autoprinted=False(formulario pre-impreso), los números de remito se asignaban después de generar el PDF (en el controller HTTP), por lo que la primera impresión salía sin número. El usuario tenía que imprimir dos veces.Solución
En
do_print_and_assign, para el casoautoprinted=False, se llamaassign_numbers(get_estimated_number_of_pages(), book_id)antes de invocardo_print_voucher(), igual que el flujo deautoprinted=True.El controller conserva la guarda
if not voucher_idsque evita doble asignación cuando ya fueron pre-asignados.Task
https://www.adhoc.inc/odoo/knowledge/180/902/tasks/67613
Forward-Port-Of: #941