[FIX] stock_orderpoint_manual_update: keep qty_forecast in DOM to avoid XPath conflict with Studio#949
Open
fw-bot-adhoc wants to merge 1 commit into
Open
Conversation
…id XPath conflict with Studio X-original-commit: a740484
Collaborator
Contributor
Author
|
@mav-adhoc @les-adhoc cherrypicking of pull request #948 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
When Studio is used on the
stock.warehouse.orderpointlist view, it raises:This happens because
stock_orderpoint_manual_updateusedposition="replace"to removeqty_forecastfrom the DOM entirely and substitute it withqty_forecast_stored. A sibling inherited view (stock.warehouse.orderpoint.tree.inherit) anchors its XPath on//field[@name='qty_forecast']. When Studio'sapply_inheritance_specsoverride processes the view combination and applies the sibling view after the replace, the anchor no longer exists — raising the error.Fix
Replace
position="replace"withposition="attributes"(making the field invisible instead of removing it from the DOM), then addqty_forecast_storedvia a separateposition="after". This keepsqty_forecastas a valid XPath anchor while hiding it from the UI.Forward-Port-Of: #948