Repository navigation
[FIX] partner_state: keep standard fields in the chatter - #156
Closed
fw-bot-adhoc wants to merge 1 commit into
Closed
fw-bot-adhoc wants to merge 1 commit into
fw-bot-adhoc wants to merge 1 commit into
Conversation
|
|
Author
|
@ced-adhoc @mav-adhoc cherrypicking of pull request #153 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
you can use 
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). X-original-commit: ed6f85d
ced-adhoc
force-pushed
the
19.0-18.0-h-126800-ced-9955-fw
branch
from
October 20, 2026 14:38
92f5166 to
9c6bdc0
Compare
Contributor
|
@roboadhoc r+ bump |
roboadhoc
pushed a commit
that referenced
this pull request
Oct 20, 2026
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes #156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <mav@adhoc.com.ar> Signed-off-by: Luciano Esperlazza <les@adhoc.inc>
roboadhoc
added a commit
that referenced
this pull request
Oct 20, 2026
les-adhoc
pushed a commit
to adhoc-dev/partner
that referenced
this pull request
Oct 20, 2026
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes ingadhoc#156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <mav@adhoc.com.ar> Signed-off-by: Luciano Esperlazza <les@adhoc.inc> In 20.0, without mail_tracking the tracking is only rendered in the message body, so the test reads the field labels from there. The README also lists the related fields that 20 tracks with the name. Cherry-picked from ff015cb (19.0).
les-adhoc
pushed a commit
to adhoc-dev/partner
that referenced
this pull request
Oct 21, 2026
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes ingadhoc#156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <mav@adhoc.com.ar> Signed-off-by: Luciano Esperlazza <les@adhoc.inc> In 20.0, without mail_tracking the tracking is only rendered in the message body, so the test reads the field labels from there. The README also lists the related fields that 20 tracks with the name. Cherry-picked from ff015cb (19.0).
roboadhoc
pushed a commit
that referenced
this pull request
Nov 2, 2026
"Changes?" now only adds fields to the chatter. Fields that Odoo tracks by default are always tracked, with or without lines in Partner State Fields. Before, the _message_track override only logged the fields with "Changes?", so a database without lines logged no partner change. The "Changes?" column now shows a computed field: it is checked and read only for fields with native tracking, and it writes the stored value for the other fields. Existing lines show the right value without a migration. The README explains the options of Partner State Fields and lists the fields that Odoo tracks on contacts by default. In 19.0, also drop the unused initial_values and state_fields_to_track from write(). closes #156 X-original-commit: ed6f85d Signed-off-by: Matias Velazquez <mav@adhoc.com.ar> Signed-off-by: Luciano Esperlazza <les@adhoc.inc> In 20.0, without mail_tracking the tracking is only rendered in the message body, so the test reads the field labels from there. The README also lists the related fields that 20 tracks with the name. Cherry-picked from ff015cb (19.0). Part-of: #154 Signed-off-by: Juan Carreras <jc@adhoc.com.ar>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://www.adhoc.inc/odoo/helpdesk.ticket/126800
Qué cambia
_track_get_fields: arranca de lo que Odoo registra por defecto y suma los campos con Cambios? (filtrados confields_get(), como hacemail). Nunca saca un campo estándar._message_track. Desde [FIX]partner_state: log to chatter fields marked with changes=True #144 dejaba pasar al chatter solo los campos con Cambios?, así que una base sin líneas en Campos de Estados no registraba ningún cambio de contactos.chatter_tracking). Si el campo elegido tiene seguimiento nativo (ir.model.fields.tracking), aparece tildado y de solo lectura. En los demás campos lee y escribechanges, como antes. Las líneas existentes se ven bien sin script de migración.El paso a Potencial (Seguir?) no cambia: lo maneja
write()concheck_fields("track").Cómo se probó
tests/test_partner_state_tracking.py: sin líneas se registra un campo estándar; con Cambios? se registra un campo que Odoo no registra y un contacto aprobado sigue aprobado; sin Cambios? un campo estándar se sigue registrando; la columna queda tildada en un campo estándar y escribechangesen otro.0 failed, 0 error(s) of 6 tests, sin warnings.changes = False; cambiar el email de un contacto deja registro en el chatter. Sin errores de consola, JS ni HTTP.19.0
El forward-port va a tener conflicto en
_track_get_fields, porque en 19.0 el método es distinto (no tiene_message_track). Al resolverlo conviene limpiar elwrite()de 19.0, que armainitial_valuesystate_fields_to_tracksin usarlos.Forward-Port-Of: #153