Skip to content

[telemetry_chargeback] Force Failures in main.yml file#375

Open
ayefimov-1 wants to merge 1 commit into
masterfrom
alexy_ck_job_6
Open

[telemetry_chargeback] Force Failures in main.yml file#375
ayefimov-1 wants to merge 1 commit into
masterfrom
alexy_ck_job_6

Conversation

@ayefimov-1
Copy link
Copy Markdown
Contributor

@ayefimov-1 ayefimov-1 commented May 4, 2026 •
edited
Loading

Improvements from feedback

  • Force failure in tasks/main.yml on failure of scenarios

Authored-by: @ayefimov-1
AI Assisted by: Claude

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 4, 2026

Unable to freeze job graph: Unable to modify final job <Job noop explicit: None implied: None source: None#0> attribute parent=noop with variant <Job feature-verification-tests-noop explicit: None implied: {MatchAny:{ImpliedBranchMatcher:master}} source: infrawatch/feature-verification-tests/.zuul.yaml@master#139>

@ayefimov-1 ayefimov-1 changed the base branch from master to alexy_ck_job_5 May 4, 2026 21:22
@ayefimov-1 ayefimov-1 mentioned this pull request May 4, 2026
Closed
@ayefimov-1 ayefimov-1 force-pushed the alexy_ck_job_5 branch 2 times, most recently from cc028a1 to 92234d4 Compare May 13, 2026 20:29
@ayefimov-1 ayefimov-1 changed the base branch from alexy_ck_job_5 to alexy_ck_job_5a May 15, 2026 14:11
@ayefimov-1 ayefimov-1 force-pushed the alexy_ck_job_5a branch 3 times, most recently from a48c3a8 to 3a395e0 Compare May 19, 2026 12:52
@ayefimov-1 ayefimov-1 changed the base branch from alexy_ck_job_5a to master May 19, 2026 15:34
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 19, 2026

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 375,8c0ad607f040b1e5e4be351dd9889db9a7bf5f58

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 19, 2026

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 375,1cf9456df73b054ca50ac5a070a6835de7383d65

@ayefimov-1 ayefimov-1 force-pushed the alexy_ck_job_6 branch 6 times, most recently from 38b7b78 to 6d75d23 Compare May 26, 2026 18:19
@ayefimov-1 ayefimov-1 mentioned this pull request May 26, 2026
Draft
@ayefimov-1 ayefimov-1 requested a review from vyzigold May 26, 2026 22:14
elfiesmelfie
elfiesmelfie requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of this is confusing. It looks like 3 separate changes, and doesn't appear to do what the title suggests.
There is a new default added for cloudkitty_test_scenarios, but no reference to that in the rest of the code changes. If you're just adding the default value to expose the var as a configurable value, then say that and submit a small PR that does only that.
Since you're exposing the cloudkitty_test_scenarios var, you should document it.

Comment thread .gitignore
Comment thread roles/telemetry_chargeback/vars/main.yml
Comment thread roles/telemetry_chargeback/defaults/main.yml Outdated
Comment thread roles/telemetry_chargeback/files/gen_synth_loki_data.py
@ayefimov-1 ayefimov-1 requested a review from danpawlik May 27, 2026 12:43
@ayefimov-1 ayefimov-1 changed the title [telemetry_chargeback] add the ability to pass test scenario names via extra-vars [telemetry_chargeback] miscellaneous May 27, 2026
@ayefimov-1 ayefimov-1 requested review from elfiesmelfie and removed request for danpawlik and vyzigold May 27, 2026 17:13
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 27, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/eda1466ca9ae4480972b780866d373e2

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 1h 39m 06s
✔️ functional-chargeback-tests-osp18 SUCCESS in 1h 22m 15s
❌ functional-tests-osp18 FAILURE in 24m 06s

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented May 28, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 28, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/f70cd222aef04c0095b79ec849c95f45

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 38m 01s
❌ functional-chargeback-tests-osp18 RETRY_LIMIT in 11m 35s
❌ functional-tests-osp18 RETRY_LIMIT in 15m 51s

@ayefimov-1 ayefimov-1 marked this pull request as draft May 28, 2026 13:24
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented May 28, 2026

recheck

@ayefimov-1 ayefimov-1 changed the title [telemetry_chargeback] miscellaneous [telemetry_chargeback] miscellaneous changes for role May 28, 2026
@ayefimov-1 ayefimov-1 marked this pull request as ready for review May 28, 2026 17:54
@elfiesmelfie
Copy link
Copy Markdown
Collaborator

elfiesmelfie commented May 28, 2026

Miscellaneous job changes, improvements collected from feedback

* clean up unused vars defined in vars/main.yml

* force failure in tasks/main.yml on failure of scenario tasks

* Minor python script enhancements requested in previous reviews

* Minor .gitignore addition

Authored-by: @ayefimov-1 AI Assisted by: Claude

Each of these could be their own changes.
The "clean up unused vars" and "minor .gitignore addition" changes would be merged really quickly, since they're self explanatory, and that would make it easier to discuss the other suggested changes

@ayefimov-1 ayefimov-1 mentioned this pull request May 31, 2026
Draft
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

The scope of this is confusing. It looks like 3 separate changes, and doesn't appear to do what the title suggests. There is a new default added for cloudkitty_test_scenarios, but no reference to that in the rest of the code changes. If you're just adding the default value to expose the var as a configurable value, then say that and submit a small PR that does only that. Since you're exposing the cloudkitty_test_scenarios var, you should document it.

Added more PRs to split these issues out of the current PR.

@ayefimov-1 ayefimov-1 closed this Jun 1, 2026
@ayefimov-1 ayefimov-1 reopened this Jun 1, 2026
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented Jun 1, 2026

This change depends on a change that failed to merge.

Change #391 is needed.

@ayefimov-1 ayefimov-1 changed the title [telemetry_chargeback] miscellaneous changes for role [telemetry_chargeback] Improvements from feedback to capture failures Jun 1, 2026
@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented Jun 1, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/bbd2d29b4b6442f9ba8257c8d289e4dc

❌ telemetry-openstack-meta-content-provider-master FAILURE in 9m 24s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@ayefimov-1
Copy link
Copy Markdown
Contributor Author

ayefimov-1 commented Jun 1, 2026

recheck

@ayefimov-1
[telemetry_chargeback]
2e6ac73 
Force failure in tasks/main.yml on failure of scenario loop

Rebase from master

add the ability to pass test scenario names via
extra-vars

Remove retrieve_loki_data.yml from this PR

Fix fail message for task  verifying flush status (#385)

Fixed fail message for on file.

Miscellaneous changes to telemetry_chargeback role
- Fixes minor issues in .gitingnore
- Cleans up directory vars that are not being used
- Adds changes requested in previous reviews to python scripts

Reorganize task execution to avoid duplicated RHELOSP-144965 test (#390)

As it was suggested by Emma in the task, we can reorganize the
tasks execution to confirm functionality and avoid duplication.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>

[telemetry_chargeback] Improvements from feedback to capture

Force failure in tasks/main.yml when failure in a test  scenarios
@ayefimov-1 ayefimov-1 changed the title [telemetry_chargeback] Improvements from feedback to capture failures [telemetry_chargeback] Force Failures in main.yml file Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfiesmelfie elfiesmelfie Awaiting requested review from elfiesmelfie

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayefimov-1 @elfiesmelfie