feat: Introduce cross namespace support#94
Open
igorbernstein wants to merge 3 commits into
Open
Conversation
Author
|
This might've been a mistake. I'm wondering if we should follow the gateway api model of ReferenceGrants instead?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes a wider approach to address feedback from #93.
The PR is noisy. I've tried to split it into three reviewable commits:
One non-obvious consequence: HeadscaleAutoApprover now watches ClusterHeadscale events and fans out to approvers across all namespaces when the referenced instance is cluster-scoped. Worth a closer look in
the third commit.
Happy to open these as separate PRs, or you can review per commit — whichever you prefer.