fix(secretstores.vault): Preserve sibling keys when setting a secret#19293
Open
skartikey wants to merge 1 commit into
Open
fix(secretstores.vault): Preserve sibling keys when setting a secret#19293skartikey wants to merge 1 commit into
skartikey wants to merge 1 commit into
Conversation
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting a secret with
telegraf secrets setwrote only the new key to the secret path, and Vault'sPutreplaces the whole secret at the path rather than merging, so every other key stored at that path was silently removed.This reads the existing secrets at the path first and sets the new key on top of them before writing back. A not-found path is treated as empty so setting into a brand-new path still works, while any other read error aborts the write so a transient failure cannot overwrite existing secrets.
Checklist
Related issues
resolves #19287