test(inputs.cpu): Avoid manual mocking#19249
Open
srebhan wants to merge 1 commit into
Open
Conversation
telegraf-tiger
Bot
added
chore
plugin/input
srebhan
changed the title
srebhan
marked this pull request as ready for review
July 17, 2026 13:21
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
skartikey
reviewed
Jul 17, 2026
Comment on lines
+91
to
+92
| var err error | ||
| expectedErrors, err := testutil.ParseLinesFromFile(expectedErrorFilename) |
Contributor
There was a problem hiding this comment.
removed redundant declaration.
Suggested change
| var err error | |
| expectedErrors, err := testutil.ParseLinesFromFile(expectedErrorFilename) | |
| expectedErrors, err := testutil.ParseLinesFromFile(expectedErrorFilename) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes testing of
inputs.cputo using actual data. This is necessary as PR #19286 will move away from theSystemPSclass. This has the drawback that mocking now only works on Linux by providing the/procfiles. However, injecting well-known data into processing will not test for OS specific issues anyway...Checklist
Related issues
related to #18141
related to #19286