feat(inputs.vsphere): Allow adding custom properties as fields by tguenneguez · Pull Request #19161 · influxdata/telegraf

tguenneguez · 2026-06-25T07:23:45Z

Summary

Add the capabilitie to collecte properties of elements.

For sample :

host :
- summary.runtime.powerState
- summary.overallStatus
- summary.runtime.inMaintenanceMode
- summary.runtime.connectionState
vm :
- runtime.powerState
cluster :
- overallStatus
- configuration.drsConfig.enabled
datastore :
- summary.accessible
resource_pool :
- overallStatus

This change collect data for VM Power Off. There was no information about this subtility.

Checklist

No AI generated code was used in this PR
AI generated code used in this PR follows the InfluxData Policy on AI-Generated Code Contributions

Related issues

resolves #18858

srebhan · 2026-07-03T09:10:04Z

Thanks for your contribution @tguenneguez! Can you please check and fix the linter issues!? Furthermore, you can't check "I've used no AI" and "I've used AI" at the same time. :-) Please fix the checkboxes in the PR description. :-)

tguenneguez · 2026-07-03T09:24:53Z

Yes, I have seen it, but I do lot off think in the same time so, i change when I have time.
I think it will be good.

srebhan

Thanks for your contribution @tguenneguez! I do have some comments in the code. IMO, the most important issues are

You are changing unrelated parts of the code resulting in a larger diff than necessary. Please avoid changing code you don't need to touch in this PR. If you want it changed, do it in a separate PR!
Spelling and comments are French AFAICS. Please check spelling and convert everything to English please!

Looking forward to your update of the PR!

srebhan · 2026-07-15T10:26:07Z

+// resourceInfo is a utility class grouping a type and relevant parameters.
+type resourceInfo struct {
+	resType     string
+	custoFields []string


This abbreviation saves one character while humpering readability a lot. Please be generous and add the m here. :-)

It's because of resourceFilter containe a resType

Sorry but custo is not a word! Use customFields please. I don't see how this is related to resType or resourceFilter at all.

srebhan · 2026-07-15T10:30:55Z

 			fields = append(fields, af...)
 		}
+		fields = append(fields, resourceInfo.custoFields...)
+		uniqueFields := removeDuplicates(fields)


fields are defined by resourceInfo.custoFields which in turn stem from user-settings, don't they? If so, wouldn't it be better to deduplicate those user-settings in Init instead of doing it in every gather cycle?

It will be, but they are agregate to addFields[resourceInfo.resType].
To be able to do this, it will be necessaire to agregate this info only one time...

I'm talking about removeDuplicates here. You are removing duplicates from something that is user-set and does not change over the lifetime of the plugin (that's at least my understanding). Instead of doing this every time you collect data you could remove the duplicates once in the plugin's Init function and save processing time by removing the function call here.

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

…uenneguez/telegraf into add-custom-properties-vsphere

srebhan

Thanks @tguenneguez for your update. I have some more comments. Please check spelling of your variables as propertie is not an English word.

srebhan · 2026-07-17T07:45:59Z

 	include          []string
 	simple           bool
 	metrics          performance.MetricList
 	parent           string
 	latestSample     time.Time
 	lastColl         time.Time
+	propertieInclude []string


Spelling. How about

Suggested change

propertieInclude []string

propertiesInclude []string

srebhan · 2026-07-17T07:47:59Z

+// resourceInfo is a utility class grouping a type and relevant parameters.
+type resourceInfo struct {
+	resType     string
+	custoFields []string


Sorry but custo is not a word! Use customFields please. I don't see how this is related to resType or resourceFilter at all.

srebhan · 2026-07-17T07:48:38Z

 }

 // findAll returns the union of resources found given the supplied resource type and paths.
-func (f *finder) findAll(ctx context.Context, resType string, paths, excludePaths []string, dst interface{}) error {
+func (f *finder) findAll(ctx context.Context, resourceInfo resourceInfo, paths, excludePaths []string, dst interface{}) error {


Having variables named the same as types is usually confusing, how about

Suggested change

func (f *finder) findAll(ctx context.Context, resourceInfo resourceInfo, paths, excludePaths []string, dst interface{}) error {

func (f *finder) findAll(ctx context.Context, resource resourceInfo, paths, excludePaths []string, dst interface{}) error {

srebhan · 2026-07-17T07:51:00Z

 			fields = append(fields, af...)
 		}
+		fields = append(fields, resourceInfo.custoFields...)
+		uniqueFields := removeDuplicates(fields)


I'm talking about removeDuplicates here. You are removing duplicates from something that is user-set and does not change over the lifetime of the plugin (that's at least my understanding). Instead of doing this every time you collect data you could remove the duplicates once in the plugin's Init function and save processing time by removing the function call here.

srebhan · 2026-07-17T08:01:12Z

+func capitalizeAfterDot(input string) string {
+	var result []rune
+	for i, r := range input {
+		if i == 0 || input[i-1] == '.' {
+			result = append(result, unicode.ToUpper(r))
+		} else {
+			result = append(result, r)
+		}
+	}
+	return string(result)
+}


Please do the capitilization in getExtraData or do it in Init if the input is based on user settings.

telegraf-tiger · 2026-07-17T12:37:39Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB	. RPM	. TAR . GZ	. ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

feat(input.vsphere) : add custom properties

7195b10

tguenneguez changed the title ~~feat(input.vsphere) : add custom properties~~ feat(inputs.vsphere) : add custom properties Jun 25, 2026

tguenneguez changed the title ~~feat(inputs.vsphere) : add custom properties~~ feat(inputs.vsphere): add custom properties Jun 29, 2026

telegraf-tiger Bot added area/vsphere feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 29, 2026

tguenneguez added 6 commits June 29, 2026 15:36

feat(inputs.vsphere) : add custom properties

f86e85f

feat(inputs.vsphere): add custom properties

cd2c9f0

Correction gocritic

8229c22

Corrige syntaxe

f6d7d90

Corrige syntax

7c879d6

Modify the syntax

174e995

srebhan self-assigned this Jul 3, 2026

Correction syntaxe

2480e21

srebhan reviewed Jul 15, 2026

View reviewed changes

srebhan changed the title ~~feat(inputs.vsphere): add custom properties~~ feat(inputs.vsphere): Allow adding custom properties as fields Jul 15, 2026

tguenneguez and others added 12 commits July 15, 2026 13:57

Retour arrière sur une modification inutile

1407119

Symplify code

899b387

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

Correction retour getExtraData

588b73b

Merge branch 'add-custom-properties-vsphere' of https://github.com/tg…

9c94760

…uenneguez/telegraf into add-custom-properties-vsphere

Corrige les tests

e617e16

Replace resType in resMType

235438b

Translate comments

5beb4b6

Corrige syntaxe

22ae6ac

Modify syntaxe

9ad4016

Correction syntaxe

e06c9c8

Correction syntaxe

48a8df7

Retire custoFields: nil,

98ba92c

tguenneguez added 5 commits July 16, 2026 09:25

Corrige filtres

705997e

Corrige les filtres

e050ea7

Corrige syntaxe

5d614ec

Rename var

29005b4

propertie => property

38f732b

srebhan reviewed Jul 17, 2026

View reviewed changes

tguenneguez added 2 commits July 17, 2026 11:58

Correction as recommanded

2781898

Only for poweredOn VM

30dc27c

tguenneguez mentioned this pull request Jul 17, 2026

Add vsphere virtual machine power state metric/label #14677

Closed

1 task

tguenneguez added 4 commits July 17, 2026 12:17

Corrige syntaxe

03a4f5b

Correction syntaxe

8e0f141

Corrige syntaxe

de26842

Corrige syntaxe

8d95e0b

	func (f *finder) findAll(ctx context.Context, resourceInfo resourceInfo, paths, excludePaths []string, dst interface{}) error {
	func (f *finder) findAll(ctx context.Context, resource resourceInfo, paths, excludePaths []string, dst interface{}) error {

Uh oh!

Conversation

tguenneguez commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Related issues

Uh oh!

srebhan commented Jul 3, 2026

Uh oh!

tguenneguez commented Jul 3, 2026

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

telegraf-tiger Bot commented Jul 17, 2026

Artifact URLs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tguenneguez commented Jun 25, 2026 •

edited

Loading