Bumped rustdesk install scripts to 1.4.3#9
Open
codiflow wants to merge 5 commits into
Open
Conversation
In line 23 the file `/etc/os-release` gets parsed and in some cases this sets the env variable `VERSION` which would override the rustdesk version variable breaking the script. So the var name was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the script
install-linux.sh:In line 23 the file
/etc/os-releasegets executed and in some cases this sets the env variableVERSIONwhich would override the rustdesk version variable resulting in a broken script. So the var name was changed toRD_VERSION.For consistency the name was changed in all other scripts as well.