feat(i18n): add support for i18next pluralization keys - #2980
Open
whomwah wants to merge 1 commit into
Open
Conversation
Introduced types for plural suffixes and a helper to strip them from keys. This enhances the translation key management in the i18n module.
whomwah
force-pushed
the
feat/add-pluralisation-typing
branch
from
July 18, 2025 15:52
0ad6bec to
79ebc40
Compare
Member
|
This looks awesome @whomwah! Thank you for the PR. We'll wait for @mazenchami to get back from paternity leave, as he's the i18n expert here at Infinite Red, but it looks pretty good to me. |
JJG1992
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the i18n keys typing doesn't support pluralisation as you store the keys with a suffix and target them without [https://www.i18next.com/translation-function/plurals].
Introduced types for plural suffixes and a helper to strip them from keys. This enhances the translation key management in the i18n module.
Checklist
Testing