Repository navigation
feat(tui): restyle the question and plan approval prompts with a quiet rail - #1541
Merged
Merged
Conversation
…t rail AskUserQuestion drops its rounded box for a thin accent rail, a header chip with an N of M counter, a bold question and dim option descriptions on their own line. Plan approval gets the same rail in its status color, a Plan chip and a solid pill for the selected action with the working keys underneath. The status lines no longer repeat the key hints, and the plan approval placeholder stops advertising keys that are not reachable.
A turn that ends while paused on a user decision subtracted two separate time.Since calls, so the summary could land just under the true duration and made TestStatusViewTurnDurationSummary flaky.
Contributor
|
🎉 This PR is included in version 0.226.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AskUserQuestion and plan approval prompts share one look now: no box, a thin accent rail on the left, a header chip and dim key hints.
Changes
N of Mcounter (hidden for a single question), the question is bold, and each option's description sits dim on its own line. Selectors use❯, multi-select uses✓/•. The free-text field is titled "Your answer".Planchip. The selected action is a solid accent pill, the others are dim, and the working keys are listed underneath. This removes a lookup of a theme color that does not exist (selection_bg).RenderRailandRenderChipon the style provider.h/l,y,nands, which are not reachable.Testing
task lintandgo test ./internal/presentation/...pass.Not in this PR
y/n/s/h/lplan approval keys are still dead. That is a keybinding bug.