Sort interfaces by priority when searching an IP address

[camilojd]

Currently ip.address() will search in all interfaces given by os.networkInterfaces(). This needs to take into account that multiple valid IPs can be found, and some of them may be preferable to others, depending on the type of network adapter.

For example, when os.networkInterfaces() returns:

{
  lo0:
   [ { address: '127.0.0.1',
       netmask: '255.0.0.0',
       family: 'IPv4',
       mac: '00:00:00:00:00:00',
       internal: true },
     { address: '10.200.10.1',
       netmask: '255.255.255.0',
       family: 'IPv4',
       mac: '00:00:00:00:00:00',
       internal: true } ],
  en0:
   [ { address: 'fe80::d9:8c22:6588:6d41',
       netmask: 'ffff:ffff:ffff:ffff::',
       family: 'IPv6',
       mac: '06:00:00:06:0e:00',
       scopeid: 4,
       internal: false },
     { address: '192.168.1.72',
       netmask: '255.255.255.0',
       family: 'IPv4',
       mac: '06:00:00:06:0e:00',
       internal: false } ]
}

The proper value for ip.address() should be 192.168.1.72, and NOT 10.200.10.1, as currently returned by node v8.1.3 on macOS 10.12.6.

[brentvatne]

I ran into this same problem, this seems valuable

[brentvatne]

should remove space before (name for consistency with the rest of the codebase

[brentvatne]

why not just return priority(a) - priority(b)?

[camilojd]

@brentvatne you're right :-) I did that to debug my code.

[brentvatne]

should remove space between function and (nic)

[camilojd]

@brentvatne just pushed a commit addressing your comments. Thanks for the review!

[camilojd]

@brentvatne travis is green 🚀

[brentvatne]

@camilojd - I would merge this if I were a maintainer for the project! alas I am not ;)

[indutny]

LGTM, with a minor suggestion.

[indutny]

Sorry for delay. I've a suggestion, what do you think about either using slice here or RegExp?

[camilojd]

@indutny slice works for me!

[camilojd]

@indutny sorry, I forgot to ping you after the change. Do you think this is good to go?