CVE-2024-29415 - Added test cases for fixed related to "isPublic() function still identifying some private IP addresses as public"#157
Open
chawladolly25 wants to merge 5 commits intoindutny:mainfrom
Conversation
Pull request from 'feature_main_A33J' to 'main'
Pull request from 'feature_main_5FYH' to 'main'
|
Why was this done as a separate PR and not part of #156? |
Author
|
Would be helpful if you can check this PR. I am planning to delete the previous PR |
chawladolly25
changed the title
|
Are we going to merge this PR soon? |
|
just bumping the question... is this going to be merged? |
bassquest
approved these changes
Jun 6, 2025
|
Is this going to be merged soon? Is it best to downgrade to v1 in the meantime? @chawladolly25 |
totus
approved these changes
Aug 15, 2025
|
Can you merge PR pls? Any blockers? |
Merged
slayfer-dev
reviewed
Sep 26, 2025
| if (normalizedAddr === -1) { | ||
| return false; | ||
| } | ||
| addr = ip.fromLong(normalizedAddr); |
There was a problem hiding this comment.
Why does it need to rewrite the addr value after the check?
|
I have also created a PR if this one doesn't pass. #165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases for fixed related to "isPublic() function still identifying some private IP addresses as public"