Fix small issues in primitives.py - #331
Open
alexfikl wants to merge 7 commits into
Open
Conversation
alexfikl
commented
Aug 7, 2026
Comment on lines
-2041
to
+2070
| extra_args = provided_arg_names - kernel_arg_names | ||
| if missing_args: | ||
| if extra_args := (provided_arg_names - kernel_arg_names): |
Collaborator
Author
There was a problem hiding this comment.
I forgot to fix this a long time ago. It's correct now, right?
Collaborator
Author
There was a problem hiding this comment.
Hm, this fails some tests currently. The issue is that e.g. NeumannOperator for Helmholtz takes in some kernel_arguments for the kernel, but the representation also uses a LaplaceKernel, which is going to complain because it got an extra k when it gets passed the same kernel_arguments.
I would be inclined to convert the raise into a warning? I don't know..
I've currently just removed the kernel_arguments from that call (in a4295c9), so it should work 🤷
alexfikl
force-pushed
the
fix-primitves-folds
branch
from
August 7, 2026 13:13
2d6abd2 to
977566d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably best viewed commit by commit. It just moves things around and updates some phrasing/typos.
The baseline changes are due to moving some things around + probably from the
boxtreeFMM typing PR. (updated ./.basedpyright/baseline.json with 5430 errors (went down by 82)😁)