tests: defer repo clippy lint levels to Cargo.toml#241
Closed
Wyatt Gill (wyattgill9) wants to merge 1 commit into
Closed
tests: defer repo clippy lint levels to Cargo.toml#241Wyatt Gill (wyattgill9) wants to merge 1 commit into
Wyatt Gill (wyattgill9) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing
checks.x86_64-linux.evalassertion after #239 moved the Rust lint policy out oflib/rust.nixand into[workspace.lints]inCargo.toml. That PR updated the parallelcargoUnitWorkspace.policy.clippy.deniedLintsassertion (tests/default.nix:2978) but missed the equivalentrepoPackages.minecraft-nbt.passthru.policy.clippy.deniedLintsassertion, so the eval check started failing with:Both Nix policies now expose
deniedLints = [ ]because the lint levels live inCargo.toml. The assertion is updated to mirror the already-fixed sibling: it checksdenied == [ ]and the message now reads "repo Rust clippy policy should defer default lint levels to Cargo.toml".Validation
nix run .#lint