Making expand_mini function modular - #14
Open
yelenacox wants to merge 8 commits into
Open
Conversation
torstees
reviewed
Aug 17, 2026
torstees
left a comment
torstees
left a comment
Collaborator
There was a problem hiding this comment.
There are a couple of comments that aren't really guaranteed to require attention, but I would like for you to look into them before merging this in. Everything else looks good!
| if has_permissible or not has_ontology: | ||
| logger.info(f"Skipping {name}. Does not require expansion") | ||
| logger.info(f"Skipping {name}. Does not require expansion.") | ||
| enum_count += 1 |
Collaborator
There was a problem hiding this comment.
Let's see if these counters can be organized a bit better to make it easier to follow the logic for increments.
| "permissible_values" in enum and enum["permissible_values"] | ||
| ) | ||
|
|
||
| has_reachable = enum.get("reachable_from") or {} |
Collaborator
There was a problem hiding this comment.
My gut seems to want me to believe that this logic could very likely be the same as the minus. Can you give the possibility of creating a generic function that builds those "reachable_from" structures that can be used for both minus and the other?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mini --clearwill not deletepermissible_valuesifreachable_fromis not presentCloses #12