Update GHA approach - #3
Open
RobertJCarroll wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Ok, this did address the warning re deprecation. It does show another concern I had, though: the action should fail out or adjust it's output when an existing, published release already exists. The updating behavior is good when the release is in draft. |
Collaborator
Author
|
Immutable releases might do it per https://github.com/softprops/action-gh-release , but I am not sure I can make that change in this org. |
Collaborator
Author
|
Ok, it appears to be failing as expected. It might be slightly more efficient to run a simpler action that triggers the more complex full run (as the checkout is expensive), but I don't expect it to be a big deal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change a deprecated GHA component + make sure behavior is good overall.