Add endpoint to get usernames by id#73
Open
aaronb12-ux wants to merge 3 commits intomainfrom
Open
Conversation
…nto add-endpoint-to-get-usernames-by-id
aaronb12-ux
changed the title
naomitzhao
requested changes
May 10, 2026
Contributor
naomitzhao
left a comment
naomitzhao
left a comment
There was a problem hiding this comment.
Works well! Just had a nit about function naming. Also please format the files you changed with Prettier! Other than that, I can approve this soon.
| import { MongoClient, ObjectId } from 'mongodb'; | ||
|
|
||
|
|
||
| export async function getDocument(client: MongoClient, id: string) { |
Contributor
There was a problem hiding this comment.
I think this function can be given a more descriptive name-- maybe getUserById
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an endpoint to get the usernames by ID:
It exists in the already existing users router.
router.get('/:id', getUserDocument) //gets the entire user document of a user NOT in the session
where 'id' is the id of the user. This endpoint returns the entire document in the users collection of the users.