Open
Conversation
naomitzhao
requested changes
May 10, 2026
Contributor
naomitzhao
left a comment
naomitzhao
left a comment
There was a problem hiding this comment.
Fireee! This is just a tiny nit, but we just remove a few unused imports from these files before merging?
| @@ -0,0 +1,98 @@ | |||
| 'use client'; | |||
|
|
|||
| import React from 'react'; | |||
Contributor
There was a problem hiding this comment.
I think this import is unused, could we remove it?
Comment on lines
+3
to
+5
| import Image from 'next/image'; | ||
| import styles from './page.module.scss'; | ||
| import React, { useState } from 'react'; |
Contributor
There was a problem hiding this comment.
Ik they weren't added in this PR, but could we remove the unused imports in this file? :P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HomePagination component
Summary of changes
currentPage) and total number of pages (totalPages), and also a function that should be called when switching pages (onPageChange()). These props are passed in from the Homepage page.tsxtotalPages > 6, the component will "hide" some of the page numbers with..., always reserving the last slot for the last page numberVideo Demos
When
totalPages <= 6:pagination6pageDemo.mov
When
totalPages > 6:pagination10pageDemo.mov
How to Test
Run the frontend locally; the HomePagination component is already rendered on the home page (the positioning of the component on the home page is temporary and will be adjusted once product listings are implemented into the home page). In src/app/(pages)/(home)/page.tsx, you can change the value of
totalPagesto change the number of pages displayed in the component