Repository navigation
Refactor Curl execution and error handling - #16
Merged
Merged
Conversation
curl_close() has had no effect since PHP 8.0 and is deprecated as of PHP 8.5, which triggers an E_DEPRECATED notice on every request. The call is now only made on PHP < 8.0, so PHP 7.4 support is preserved. Also changed the curl_exec() check to `=== false`, since an empty response body (e.g. 204 No Content) previously threw a CurlException with error code 0.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The empty-response fix needs regression coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Refines cURL response handling across supported PHP versions.
Changes:
- Accepts successful empty response bodies.
- Avoids deprecated
curl_close()calls on PHP 8+.
| File | Description |
|---|---|
src/CurlClient.php |
Updates execution checks and version-specific cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi @dahn15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

curl_close() has had no effect since PHP 8.0 and is deprecated as of PHP 8.5, which triggers an E_DEPRECATED notice on every request. The call is now only made on PHP < 8.0, so PHP 7.4 support is preserved.
Also changed the curl_exec() check to
=== false, since an empty response body (e.g. 204 No Content) previously threw a CurlException with error code 0.