Changed from previous lockpick versioning scheme to be more flexible (and match with atmosphere).#7
Open
auggeythecat wants to merge 1 commit into
Open
Changed from previous lockpick versioning scheme to be more flexible (and match with atmosphere).#7auggeythecat wants to merge 1 commit into
auggeythecat wants to merge 1 commit into
Conversation
…oom for non-firmware/key derivation related updates. Aka, bug fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason this is needed, is because there are currently 3 'mainstream' (aka, widely used) distributions of LockpickRCM.
Due to various bug fixes, and similar things, one of them is on
1.9.18, (which is mostest correctest), one is1.9.19, and one is1.9.20. These all support a maximum of 22.x.x, but based on the established naming convention, the latter two would be 23.x.x and 24.x.x respectively. It is becoming difficult to point people to it properly, and I see this getting much harder in future updates. So, I suggest we fix this now, so we don't have to deal with it later.With the new suggestion, major and minor version would correspond to the major and minor versions of the corresponding atmosphere release, and bugfx would be for, well, bug fixes. This way it could just be referred to as, for example,
1.12.xand it would be accurate for any repo, (no matter how many bug fixes).The three repos that this change is being pr'ed to, are as follows: https://github.com/impeeza/Lockpick_RCMDecScots, https://github.com/kofysh/Lockpick_RCM, and https://github.com/THZoria/Lockpick_RCMaster.
Thanks!