transpile: Translate EnumConstant with associated constants - #1659
Open
Rua wants to merge 3 commits into
Open
Conversation
Rua
marked this pull request as draft
April 16, 2026 10:16
Rua
force-pushed
the
enum-associated-constant
branch
28 times, most recently
from
April 20, 2026 19:59
d2aced7 to
17365e3
Compare
Rua
force-pushed
the
enum-associated-constant
branch
4 times, most recently
from
April 20, 2026 21:26
cb01918 to
43e8bfe
Compare
kkysen
added a commit
that referenced
this pull request
Apr 24, 2026
…1746) - Fixes #1660 This was quite tricky to implement, but it's now working and #1659 passes its tests with these additions. Only `const` associated items are supported. `type` items could be added later, but `fn` is probably never going to work because they are too complex to test for equivalence.
Rua
force-pushed
the
enum-associated-constant
branch
4 times, most recently
from
May 1, 2026 18:46
1168841 to
d6b6fea
Compare
Rua
force-pushed
the
enum-associated-constant
branch
2 times, most recently
from
May 3, 2026 17:18
28f1743 to
804eecf
Compare
Rua
force-pushed
the
enum-associated-constant
branch
from
May 5, 2026 19:22
804eecf to
ef79d45
Compare
Rua
force-pushed
the
enum-associated-constant
branch
3 times, most recently
from
August 4, 2026 20:48
4b2c73d to
7688d77
Compare
Rua
marked this pull request as ready for review
August 4, 2026 21:31
Rua
force-pushed
the
enum-associated-constant
branch
from
August 4, 2026 22:29
7688d77 to
9d477e1
Compare
Rua
force-pushed
the
enum-associated-constant
branch
from
August 6, 2026 07:59
9d477e1 to
93fe084
Compare
ahomescu
requested changes
Aug 6, 2026
| }) | ||
| .collect(); | ||
|
|
||
| let impl_block = mk().impl_item(mk().ident_ty(enum_name), constants); |
Contributor
Author
There was a problem hiding this comment.
I've given it the same span as the newtype struct. I don't know if that's correct, I'm not sure what the purpose of the spans is.
Rua
force-pushed
the
enum-associated-constant
branch
from
August 7, 2026 07:35
93fe084 to
937303a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reorganize_definitions#1746