Conversation
bump dependencies segment hint refactor optimizations refactor, fix unregister only bind loopback simplify duration parsing playlist hint simplify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the changes needed to properly use HLS in the Immich app for both iOS and Android. As it happens, the iOS
VideoProxyServerimplementation used for mTLS and such ended up being extremely useful here to fill up gaps in the AVPlayer API (setting hints, viewing the playlist segments, and later potentially forcing a particular variant), so it's used in general now. No visible performance regression from this change; it slightly lowered latency if anything.