Skip to content

Define cylinder and equirect initialization validation - #341

Open
cabanier wants to merge 1 commit into
immersive-web:mainfrom
cabanier:fix/333-layer-init-validation
Open

cabanier wants to merge 1 commit into
immersive-web:mainfrom
cabanier:fix/333-layer-init-validation

Conversation

@cabanier

@cabanier cabanier commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

Fixes #333.

This change:

  • Rejects invalid cylinder initialization values with TypeError for both WebGL and media layers.
  • Explicitly clamps equirect initialization values consistently with existing attribute behavior.
  • Refactors the shared initialization algorithms to accept resolved values from either WebGL or media dictionaries.
  • Resolves media cylinder aspectRatio locally without mutating the input dictionary.
  • Removes the unsupported infinity wording for an IDL float radius.

This update will bring the algorithms in the spec in line with the implemented behavior and normative language earlier in the spec.


Preview | Diff

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add validation for equirect and cylinder layers' init values

1 participant