SHEN-16540 Add write page index option to ParquetWriter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, users do not have the option to write the page index when writing parquet files. This restricts user side optimisation as it prevents page level stats from being persisted. Let's pipe through this option as a table property so that users can write page level indexes.
|
Seems good to me, but the checks are failing. |
Author
Yep, seems possible that the pipeline is different for branch PR's vs fork PR's - given I have not touched a bunch of the files that it is complaining about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users do not have the option to write the page index when writing parquet files. This restricts user side optimisation as it prevents page level stats from being persisted.
Let's pipe through this option as a table property so that users can write page level indexes.
I was getting blocked trying to create a branch on the main imc-trading repo so am submitting PR through a fork instead