fix(create-pr): keep assistant names out of generated descriptions - #190
Merged
Conversation
The generation prompt already said not to mention the tooling, but that reads as 'do not credit yourself' rather than 'do not describe a change that happens to concern it'. When a diff touched the contributor guide's commit-message convention, the model described it accurately — and put an assistant's name in prose in a public PR description. The prompt now states that the rule holds even when the diff is about this tooling, and gives the neutral phrasing to use instead. The convention in the contributor guide is widened to match: no mention anywhere in a description, not just no footer. Naming a changed file by its real path stays fine, since that is the file's actual name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-pr.sh's generation prompt told the model not to mention the tooling, but that instruction read as "don't credit yourself" rather than "don't describe a change that happens to concern it." When a diff touched the contributor guide's own commit-message convention, the model described it accurately — and named an assistant in prose, in a public PR description.Changes
CHANGELOG.mdupdated with the fix entry.Files
scripts/git/create-pr.shCLAUDE.mdCHANGELOG.md