Prospero: validate physical patch writes - #14
Draft
ygordreyer wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11.
Problem
On newer PS5 firmware, XML patching could continue after a write failed. The physical writer also reused a cached
p_procand did not revalidate the target mapping immediately before each chunk, which could leave a stale kernel pointer in the launch path.Changes
allprocwithout the SDK process cache on Prospero above 8.20.userland_copyin2errors, stop at the first failed line, and skip the later PRX pass.Test
-Wall -Werror.The console run used the instrumented test branch with kstuff-lite 1.09 and a per-title no-pause rule. This PR contains only the production writer and error-handling changes. It does not roll back XML lines completed before a later failure.