Skip to content

Raise our Screenshot Diff Threshold - #9635

Closed
jrjohnson wants to merge 1 commit into
ilios:masterfrom
jrjohnson:raise-screenshot-diff-threshold
Closed

jrjohnson wants to merge 1 commit into
ilios:masterfrom
jrjohnson:raise-screenshot-diff-threshold

Conversation

@jrjohnson

Copy link
Copy Markdown
Member

Giving us a little bit more room here because we're getting a lot of false positives.

Giving us a little bit more room here because we're getting a lot of false positives.
@netlify

netlify Bot commented Oct 20, 2026

Copy link
Copy Markdown

✅ Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 0e68fd4
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6ad7ee9a85264c0f245ca14e
😎 Deploy Preview https://deploy-preview-9635--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Visual Diff Report — FAILED

2176 images compared: 579 different · 1597 identical

Details

Differences (579)

File Diff % Notes
desktop-Acceptance _ API Version Check_Warning shows up when api versions do not match__light.png 0.02%
desktop-Acceptance _ assign students_visiting _admin_assignstudents__light.png 0.01%
desktop-Acceptance _ Course - Cohorts_manage cohorts__light.png 100.00% ⚠️ Dimension mismatch (1046x1000, Data length: 4184000 → 1047x1000, Data length: 4188000)
desktop-Acceptance _ Course - Competencies_collapsed competencies renders__light.png 0.16%
desktop-Acceptance _ Course - Leadership_collapsed leadership__light.png 0.19%
desktop-Acceptance _ Course - Leadership_list leadership__light.png 0.20%
desktop-Acceptance _ Course - Learning Materials_list double linked learning materials__light.png 0.04%
desktop-Acceptance _ Course - Multiple Objective Parents_initial view__light.png 0.14%
desktop-Acceptance _ Course - Objective List_list objectives without MeSH UI__light.png 0.06%
desktop-Acceptance _ Course - Objective List_list objectives__light.png 0.61%
desktop-Acceptance _ Course - Objective List_long objective__light.png 0.20%
desktop-Acceptance _ Course - Objective Mesh Descriptors_cancel changes_default background color_light.png 0.27%
desktop-Acceptance _ Course - Objective Mesh Descriptors_cancel changes_managed background color_light.png 0.17%
desktop-Acceptance _ Course - Objective Mesh Descriptors_manage terms_default background color_light.png 0.27%
desktop-Acceptance _ Course - Objective Mesh Descriptors_manage terms_managed background color_light.png 0.17%
desktop-Acceptance _ Course - Objective Mesh Descriptors_save terms_default background color_light.png 0.27%
desktop-Acceptance _ Course - Objective Mesh Descriptors_save terms_managed background color_light.png 0.17%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_1st objective list item collapsed again_light.png 0.06%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_1st objective list item collapsed_light.png 0.06%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_1st objective list item expanded_light.png 0.05%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_2nd objective list item collapsed again_light.png 0.06%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_2nd objective list item collapsed_light.png 0.06%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_2nd objective list item expanded_light.png 0.13%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_3rd objective list item collapsed again_light.png 0.06%
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync_objective description and parent objectives faded statuses are synced_3rd objective list item collapsed again_light(1).png 0.06%
… and 554 more

Download the results.

@jrjohnson

Copy link
Copy Markdown
Member Author

Doesn't help.

@jrjohnson jrjohnson closed this Oct 21, 2026
@jrjohnson
jrjohnson deleted the raise-screenshot-diff-threshold branch October 21, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant