Add WebP support to ext/exif#74
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
WebP stores EXIF metadata in a RIFF "EXIF" chunk whose payload is a raw TIFF block, the same data JPEG carries after its APP1 marker. Walk the RIFF chunks, locate the EXIF chunk, and hand its payload to the existing exif_process_TIFF_in_JPEG() parser, so no third-party library is needed. The chunk is accepted regardless of the VP8X extended-format flag, and an optional leading "Exif\0\0" marker is skipped when an encoder emits one. Closes phpGH-19904
Owner
Author
|
Submitted upstream: php#22213. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebP keeps EXIF metadata in a RIFF
EXIFchunk whose payload is a raw TIFF block, the same bytes a JPEG carries after itsAPP1/Exif\0\0marker, soexif_read_data()can read it by handing the chunk to the existingexif_process_TIFF_in_JPEG()parser, with no new dependency. Chunk scanning is bounded by the declared RIFF size, theEXIFchunk is accepted whether or not the VP8X extended-format flag is set, and an optional leadingExif\0\0marker is tolerated. The phpinfo supported-filetypes line now lists what exif actually parses (it was missing HEIF too).Fixes php#19904