Conversation
…rgument Frameless calls pass the caller's operand zvals straight to the handler without taking a reference, so an argument freed by a __toString() that the handler itself triggers leaves it reading freed memory. Take a reference on array and array-or-string arguments in the Z_FLF_PARAM_ARRAY* macros and release it at flf_clean, so a destructive write from userland separates the array instead. The handle is kept in a local because the operand may be a reference slot that userland overwrites. This covers in_array(), preg_replace(), str_replace(), strtr() and implode(); the per-function guards from 8ce7f7f stay, since implode/1 parses its argument without the macros and php_implode() is public API. Z_FLF_PARAM_STR still reads its string directly on the fast path, so phpGH-21639 stays open. Fixes phpGH-23725
Owner
Author
|
Submitted upstream as php#23731. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frameless calls hand the handler the caller's operand zvals without taking a reference, so an argument freed by a __toString() the handler triggers leaves it reading freed memory. Taking the reference in the Z_FLF_PARAM_ARRAY macros generalizes the per-function guards from 8ce7f7f, as suggested on php#23221, which this supersedes. Z_FLF_PARAM_STR still reads its string directly on the fast path, so phpGH-21639 stays open.
Fixes php#23725