Repository navigation
[Vulcan] Fix numeric symmetric nickname delimiters - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHP converts numeric-string array keys to integers. Cast the delimiter keys back to strings at the two strict-comparison sites so numeric symmetric nickname delimiters obey the same boundary rules as other delimiters.
John 0foo,do,bar0 Smithwith0 => '0'no longer produces a false standalone credential ambiguity.Smith0, John0retains its structural comma and surname-first interpretation instead of treating a mid-token0as a nickname opener.Validation
Rebased after #23 merged onto
612656f5ccb5b2aaf0c89929ccf246bea77e1851; inspected current README, configuration, issues and open PRs (none), and verified every tracked base blob. No repository AGENTS or skills are present.Local limitation: reused existing development dependencies in the cloud fallback; no fresh local Composer audit or PHP 8.3/8.5 execution. CI run 39680640552 passed all five expected jobs for exact head
29e6d578906573cb986ade9f6fe6abb37ffbfb36: PHP 8.3/8.4/8.5 each passed 1388 tests / 4012 assertions and Composer audit, plus static analysis and code style. No checks failed or skipped. No speed or memory improvement is claimed.